-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featuer/add support for wasm #26
Conversation
@hosseind2 thanks for your first contribution here! Have you tested this with the wasm being invoked inside a browser? If yes, can you share the steps to reproduce? |
welcome |
I tested it in browser and with new approach works correctly |
Cargo.toml
Outdated
edition = "2018" | ||
|
||
|
||
[dependencies.web-sys] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this dependency conditional on wasm32
@amodm fixed |
Lovely. Thanks. The build still fails, but I need to fix it. FYI, this will take some time to show up in the release, because I first need to fix a bunch of things on my CI. |
ok thank you so much |
@hosseind2 this is out as 0.5.5 |
No description provided.